Request ephemeral Hypernode when necessary #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdloo
reviewed
Sep 12, 2022
src/DeployRunner.php
Outdated
| $this->log->info(sprintf('Successfully requested ephemeral Hypernode, name is %s.', $ephemeralApp)); | ||
| $this->log->info('Waiting for ephemeral Hypernode to become available...'); | ||
| $this->waitForEphemeralApp($ephemeralApp); | ||
| $this->log->info('Ephemeral Hypernode has become available!'); |
tdgroot
commented
Sep 12, 2022
tdgroot
force-pushed
the
create_ephemeral_hypernode
branch
11 times, most recently
from
eecadbd to
be3083b
Compare
tdgroot
force-pushed
the
create_ephemeral_hypernode
branch
from
be3083b to
58262d3
Compare
tdgroot
force-pushed
the
create_ephemeral_hypernode
branch
from
1f383fc to
b913e28
Compare
…o create_ephemeral_hypernode Conflicts: runtests.sh
tdgroot
force-pushed
the
create_ephemeral_hypernode
branch
from
cc12385 to
7d82205
Compare
Contributor
AlexanderGrooff
left a comment
AlexanderGrooff
left a comment
There was a problem hiding this comment.
Couple of things. First of all, looks like a lot of great features! However, it's a lot of features in a single PR.
If we're going to merge this to master I'd like to do this in separate PRs. The easier route would be to base this on a separate v3 branch, just like we already do in deploy-configuration
| @@ -0,0 +1 @@ | |||
| ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQDqf5tGbhjIbRQJ40bTvw69z0kUHQEeDtGkX5DTzXJ1IPHcFpbq+nxc3f++45V8FA3fq31xTjCR3+TWy/AGCVmuntVwJVCEaC/U3X0YDscmzAA4LEOfmMHIGnrJdeTJS4+N6L5uIlZqyBIeJXyEEgFpcHm4i1HGm13DR/XG7lTaXSkRI9IVb0i3S0VdrRjtqkg4M3ZjgNfAwmoDE3dGNwIBH5EVy8t/YNj/RH0TNdhTDL3AGwne6h2bTWb5SNLHNXvu2Wc5aiJlvn2E2W7mcpnPxEkVs1AeDEaPHcLaGE2+Bt/I4ntyjOy9pFDcf28sPKj76S3Sq0Wwdb8rYmT+lerIPfjwj1VPXTU1dhvDJ1ffTufp3Sn67qi7NfBMYayYxLJWh9q84RHgYhog2SNXM+autsTU40GDZUtDtORRZ+Rg5i1cGxUCRT+Fpcx3aFCM/yTLvU80qZkmfgkQwKnGCCFygDsXPuFbyRXRz9MI1+lYGg17ufW5HSHrAw34Rw2yd8k= hypernode-deploy-ci | |||
Contributor
There was a problem hiding this comment.
Where is this file used?
Member
Author
There was a problem hiding this comment.
This is the pub key of the keypair used to login to hndeployintegr8. I could leave it out
| * @throws HypernodeApiServerException | ||
| * @throws TimeoutException | ||
| */ | ||
| public function waitForAvailability(string $ephemeralHypernode, int $timeout = 900): void |
Contributor
There was a problem hiding this comment.
Why not make this available in the api client itself instead of in the deploy library?
Member
Author
There was a problem hiding this comment.
Good question, I think it'd be nice to do that later on
AlexanderGrooff
approved these changes
Sep 19, 2022
…o create_ephemeral_hypernode � Conflicts: � src/Command/Build.php � src/Command/Deploy.php � src/DeployRunner.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.